fix(list): populate RUNTIME column in func list - #4010
Conversation
The RUNTIME column in `func list` was always empty. Each lister (Knative, k8s, KEDA) had `runtimeLabel := ""` hardcoded and never read from the deployed resource. The `function.knative.dev/runtime` label is already set on all deployed resources via GenerateCommonLabels at deploy time, so the fix is to read it back from the resource's labels in each lister. Issue knative#4009
knative-prow
Bot
added
size/S
|
Hi @pmeida. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
Bot
added
the
do-not-merge/work-in-progress
knative-prow
Bot
removed
the
do-not-merge/work-in-progress
pmeida
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, pmeida The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
2 participants
Changes
func listalways showing an emptyRUNTIMEcolumn for all deployers (Knative, k8s, KEDA)/kind bug
Fixes #4009
Release Note
Docs