feat(list): add replica count - #4011
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pmeida The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @pmeida. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
func list outputfunc list showed no replica information, making it impossible to tell at a glance how many instances of a function were running without reaching for kubectl. Adds a Replicas field to ListItem populated by each deployer backend: k8s reads deployment.Status.ReadyReplicas, keda fetches the backing Deployment and does the same, and knative reads ActualReplicas from the latest ready Revision. The REPLICAS column is added to the plain text output. Integration tests assert that a deployed function reports at least one replica.
c3889fe to
20af44d
Compare
|
you have conflicts here, otherwise looks good |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Changes
REPLICAScolumn tofunc listoutput - each deployer backend (k8s, keda, knative) populates aReplicasfield onListItemfrom the live deployment state/kind enhancement
Fixes #4004
Release Note
Docs