Expose nodeSelector in knative-operator Helm chart - #2358
magic-peach wants to merge 1 commit into
Conversation
The chart already exposes affinity and tolerations for the operator and operator-webhook deployments, but scheduling to a dedicated node pool with a plain nodeSelector meant falling back to a more verbose affinity.nodeAffinity expression. Add nodeSelector alongside the existing affinity and tolerations values for both deployments. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
|
Hi @magic-peach. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
Bot
added
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kahirokunn, magic-peach The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This branch has not been deployed
2 participants
Fixes #2305
The chart already exposes
affinityandtolerationsfor the operator and operator-webhook deployments, but scheduling to a dedicated node pool with a plainnodeSelectormeant falling back to a more verboseaffinity.nodeAffinityexpression instead. This addsnodeSelectoralongside the existingaffinityandtolerationsvalues for both deployments, matching the pattern already used for those two fields.Tested with
go build ./...,helm linton the rendered chart, andhelm templatewith default values (confirms no nodeSelector block renders, matching existing behavior for affinity/tolerations) and with nodeSelector values set (confirms it renders correctly under spec.template.spec for both deployments).