Skip to content

chore: remove obsolete helm list repos space#1011

Closed
mbevc1 wants to merge 2 commits into
mainfrom
20260709_remove_space
Closed

chore: remove obsolete helm list repos space#1011
mbevc1 wants to merge 2 commits into
mainfrom
20260709_remove_space

Conversation

@mbevc1

@mbevc1 mbevc1 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

There is a leftover space at the end of help command. Let's clean it up

@mbevc1 mbevc1 added documentation Improvements or additions to documentation go Pull requests that update go code labels Jul 9, 2026
@claude

claude Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Claude finished @mbevc1's task in 47s —— View job


Review: remove obsolete list repos help space

  • Read the changed file and PR diff
  • Verify the earlier regression concern is resolved
  • Build check (go build ./...) — passes

Findings

The earlier review flagged a regression: removing the trailing space from listReposShortDesc would have made the long help render as ...for an org.The results... because listReposLongDesc concatenates the two strings.

That has been fixed in commit 02074f34. The space was correctly moved to the start of the long-desc string:

const listReposShortDesc = `List repos for an org.`

const listReposLongDesc = listReposShortDesc + ` The results are always paginated:

This keeps the short description clean (no trailing space) while preserving correct spacing in the long help output — exactly the recommended fix. ✅

Nothing else stands out: the change is purely cosmetic in help text, no logic touched, and go build ./... compiles cleanly.

LGTM 👍

Comment thread cmd/kosli/listRepos.go Outdated
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
@mbevc1 mbevc1 enabled auto-merge (squash) July 9, 2026 17:55
@mbevc1 mbevc1 disabled auto-merge July 9, 2026 21:01
@mbevc1

mbevc1 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Implemented in #1013

@mbevc1 mbevc1 closed this Jul 9, 2026
@mbevc1 mbevc1 deleted the 20260709_remove_space branch July 9, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant