-
Notifications
You must be signed in to change notification settings - Fork 9
feat(jira): add --jira-trailer flag to extract Jira issue key from git trailer #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vidhu-balad
wants to merge
23
commits into
main
Choose a base branch
from
feat/jira-trailer-flag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8ebcaf2
feat(jira): add --jira-trailer flag to extract issue key from git tra…
vidhu-balad 7f8d11d
test: register --jira-trailer in empty-flag-audit coverage
vidhu-balad 537dd16
Merge branch 'main' into feat/jira-trailer-flag
vidhu-balad 2d7398a
Update cmd/kosli/attestJira_test.go
vidhu-balad 11c68b5
fix(attest jira): add --jira-trailer flag with edge case fixes and ac…
vidhu-balad d166591
fix(jira trailer): trim whitespace from trailer key; add branch-not-s…
vidhu-balad b2fb1c3
Update cmd/kosli/root.go
vidhu-balad 678021b
test(attest jira): pin --jira-trailer/--jira-secondary-source mutual …
vidhu-balad 3226b5d
docs(attest jira): fix inaccurate and contradictory help text
vidhu-balad 044a76a
fix(attest jira): reject blank-ish --jira-trailer; test empty trailer…
vidhu-balad 5494618
fix(gitview): extract NormalizeTrailerKey; fix Unicode slice bug; ali…
vidhu-balad e6c984d
fix(attest jira): warn when trailer key present but value is empty
vidhu-balad 056f581
fix(attest jira): normalise trailer key before use in run()
vidhu-balad c013c91
test(attest jira): pin TrailerKeyExists warning path
vidhu-balad 6cb8c8d
test(attest jira): pin bare-trailer warning; fix example comment
vidhu-balad 0ccf62f
test(attest jira): pin --ignore-branch-match warning; add jira-traile…
vidhu-balad d0c1d89
fix(gitview): enforce git trailer semantics; reject invalid trailer keys
vidhu-balad ae06b04
docs: use plain language for trailer block scanning semantics
vidhu-balad da06c97
fix(attest jira): split trailer warning into three distinct cases
vidhu-balad 7cc641b
docs(attest jira): fix contradictory wording in --jira-trailer long desc
vidhu-balad 67630b6
fix(attest jira): distinguish trailer absent vs outside last block
vidhu-balad 43934bc
docs(root): fix contradictory wording in jiraTrailerFlag help
vidhu-balad e7018a5
refactor(gitview): extract scanLines to unify trailer matching logic
vidhu-balad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.