-
Notifications
You must be signed in to change notification settings - Fork 9
fix(config)!: stop loading the config file from the working directory #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
883e90b
fix!: stop loading the Kosli config file from the working directory
pbeckham d0357d8
fix(config): warn on any ignored working-directory config, not a key set
pbeckham 9157426
fix(config): scope the warning to who lost behaviour, and detect temp…
pbeckham 3d2c424
docs(config): say in the help text that the current directory is not …
pbeckham 6d13ebc
fix(config): bound the warning's read to regular files and to who los…
pbeckham f9f8582
fix(config): read the Kosli --config-file flag from the root, not the…
pbeckham 435baa6
test(config): stop the shadowing test from reaching a real cluster
pbeckham 8a7b9ee
fix(config): do not offer remedies the running command cannot honour
pbeckham 907e671
fix(config): report only the file viper would have loaded
pbeckham da5322a
fix(config): keep looking past a directory named like a config file
pbeckham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.