Repository navigation
fix: unify cross-epic readiness consumers (T12293) - #2953
Merged
Merged
Conversation
Contributor
|
CLEO merge-close receipt: the store owner's sweep (
{
"prNumber": 2953,
"mergeSha": "035c9db8f388ef7d183165ad33459e93d336f0f2",
"headSha": "646fdd48ece0e12e7e816dc1525dc6fd3679afde",
"directives": [
{
"kind": "closes",
"taskId": "T12293",
"acs": [
"AC1",
"AC2",
"AC3",
"AC4",
"AC5",
"AC6",
"AC7"
]
}
],
"errors": [],
"ciGreen": true
} |
Owner
Author
|
CLEO merge-close: T12293 is waiting to close from this PR (re-checked every sweep): /Users/keatonhoskins/Library/Application Support/cleo/worktrees/857f8997875f12e3/T12293 has 646fdd4 checked out, which does not contain PR #2953's merge commit 035c9db. A squash- or rebase-merged branch never contains its merge commit, so the tools must run on the merged tree; evidence.ciSatisfies is set, so ci: needs no local run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A cancelled cross-epic prerequisite could admit work through
startwhilenextand spawn blocked it; archived prerequisites produced the opposite disagreement. WorkGraph planning also treated every declared dependency as blocked. Studio graph filtering could hide a satisfied prerequisite and give its pending dependent a false blocked halo.Execution consumers reuse the core dependency-readiness policy: done and archived satisfy; cancelled, open, missing and unsupported evidence block. Canonical dependency evidence stays separate from selected tasks, hierarchy, candidate populations and counts. Required reads fail explicitly. Completion retains its separate cancellation and waiver semantics.
WorkGraph plans resolve real prerequisite statuses. Studio retains declared edge identities and supplies only prerequisite IDs/statuses independently of displayed nodes, including archives and records outside the node cap. Status and text filters therefore preserve readiness. Failed Explorer reads display an unavailable diagnostic while preserving the dashboard. Start refusals give state-specific remedies instead of suggesting completion of cancelled or nonexistent work.
CLEO tasks
Closes: T12293 AC1,AC2,AC3,AC4,AC5,AC6,AC7
Criterion evidence
blockedBy, persisted dangling edges and required read failures. Positive single-file replay passes against the matching CI production artifact.646fdd48ece0e12e7e816dc1525dc6fd3679afde: 39/39 pass, exit 0.Dependency-status consumer audit
Search scope: production TypeScript under
packages/, excluding test/spec files and generateddist/. Searches cover dependency/blocker status reads, completed/satisfied ID sets,getUnresolvedDepscallers, and ready/blocked/next/parallel selectors. Symbol impact was checked against qualified candidates and source callers; Nexus reports partial coverage, so this is not proof of complete runtime discovery.Migrated or already on the shared rule:
tasks/dependency-check,deps-ready,task-tools/score-task-priority, analysisrankForAnalysistask-work/index.assertTaskStartabletasks/task-datatasks/task-blockers,task-tree,generic-tree,task-tools/build-task-treetasks/show,task-contexttasks/graph-ops.getNextTask/getParallelTaskstasks/compute-task-view.nextActionorchestration/waves/index/bootstrap/unblock/validate-spawn,orchestrate/query-ops,tasks/plan/task-nextskills/orchestrator/startup,sentient/tickorchestration/dashboard/critical-path,classify-readinesssessions/briefing, CLIfocusmemory/brain-reasoning,intelligence/impactworkgraph/containment.readyFrontiertasks-adapter,GraphTab.isBlockedexplorer-loader,GraphTab,WorkGraphViewblockedByreferences. Status/text/node-cap filters never determine satisfaction. Evidence-only rows do not enter nodes, labels or epic counts. Required reads propagate; the dashboard marks a failed Explorer unavailable.workgraph/scaffold-plan.generatePlanningDoc(cleo workgraph plan)blockedBy; manual blocked state remains blocked, proposed work is not offered.Remaining comparisons are justified by a different domain/operation, not an alternative execution readiness rule:
Completion:
tasks/complete,done-plan,compute-task-view.readyToComplete, anddependency-check.getUnresolvedDepsintentionally accept terminal cancellation under the completion/waiver contract.getUnresolvedDepsis no longer used for start admission. Task-view execution hints use a separate shared blocker assessment.Integrity/history:
dep-graph-validatordiagnoses cancelled references and done records with failed verification; the skill orchestrator validator checks historical completion order. These are integrity/evidence diagnostics, not satisfaction predicates.validation/validate-opscounts completed tasks/AC evidence and checks containment consistency.Planning:
graph-ops.computeDependencyWaves, graph cache/order/critical-path helpers and phase dependency planning describe the supplied topology, including a final cyclic planning group. Wave membership is not current readiness. The wave status predicate is shared, while actual next/parallel admission and saga waves assess canonical evidence separately.Projection/counts:
nexus/depsreports raw resolution/permission status;stats/index.rankBlockedTask,tasks/analyze,tasks/task-analyze, saga rollups and Studio session pages count stored states or potential downstream impact; analysis candidate recommendations still use canonical shared ranking. WorkGraph SQL projects raw joined status before the shared grouping rule. Graph edge rendering filters endpoints for visibility only; it no longer filters dependency evidence. Agent lifecycle lanes consume the canonical task-view/count signal rather than inspect dependency statuses.Other dependency domains: verification-gate
depState.status === 'passed', phase/step sequencing and SQLite table dependency ordering are not task hard dependencies and do not use task status values.Recovery text:
task-work/indexcompares missing/cancelled/proposed evidence only to select a feasible remedy after the common readiness assessment; it does not change satisfaction. Open work is finished beforecomplete, cancelled work is restored or its relation reviewed, and missing identities are located/restored/corrected after identity checks.Svelte display state:
GraphTab.passesFilter, palette helpers,SvgRenderer,StatusBadge,EpicProgressCard, activity feeds and dependency-detail colours inspect visibility, stored task state or colour tokens. They do not decide prerequisite satisfaction.GraphTab.isBlockedis migrated, not exempted as legacy.WorkGraph progress buckets:
scaffold-plan.buildEpicEntryand its bottleneck/progress recommendations count selected child states;blockedChildrenis the stored blocked-status bucket. The ready/blocked-task projection assesses hard prerequisites through the shared policy.Verification
Current head:
646fdd48ece0e12e7e816dc1525dc6fd3679afde. Production source is unchanged from0cbbe7b1a; the final commit strengthens the archive visibility regression. Implementation83f24d133, main integrationf122f88cf, fixture-observation assertion0cbbe7b1a, archive visibility contract regression646fdd48e. CI: 43809726478.Independent original-source negatives on reviewed head
9ad74ba(all through one-file governed invocations):workgraph/scaffold-plan.test.tstasks-adapter.test.tsGraphTab.test.tstask-work/start-deps.test.tsexplorer-loader.test.tscross-epic-readiness-cli.test.tscleo workgraph plancontradicts done/archive oracle while the other CLI routes pass.The original logs predate additional proposed-remedy and
blockedBy/read-fault controls; those controls are included in the positive replay, not claimed as additional original failures. Logs remain intemp/readiness-rereview-*-original.log. Genuine corruption is fixture-only, foreign keys are restored to ON, and a real foreign-key violation is independently observed. No production repair or weakened guard.Changed-file Biome and diff checks pass. Architecture 43 passed / 0 failed / 1 skipped (local built-startup freshness guard; CI enforces the current build). PR-mode sync-invariant and skill-coverage gates pass; no baseline edits. Nexus impact reports partial/missing coverage, complemented by direct source callers; this is not complete runtime-call discovery.
The governor refused stale core dist (
E_WORKSPACE_STALE_DIST); the matching CI artifact then admitted all positive single-file replays without stamp overrides. Local builds remain prohibited. Full local build/suite/broad typecheck remain skipped per worker policy. Earlier matching-policy checkpoint: 431 targeted tests; the current-round replay and typed gate below are reported separately, without double-counting.Native task-anchored changeset included. No provider/model launch, self-review or merge. Independent head-specific AC verdicts and green required CI remain merge prerequisites.
Written primarily by Codex under the dispatched worker scope.
Current-round positive verification
packages/core/src/workgraph/__tests__/scaffold-plan.test.tspackages/studio/src/lib/server/tasks/__tests__/explorer-loader.test.tspackages/studio/src/lib/components/tasks/__tests__/GraphTab.test.tspackages/studio/src/lib/graph/adapters/__tests__/tasks-adapter.test.tspackages/core/src/task-work/__tests__/start-deps.test.tspackages/cleo/src/cli/__tests__/cross-epic-readiness-cli.test.ts124 passed across six individual files, each through
cleo run --wait --class test -- pnpm exec vitest run <one-file>. The actual CLI probes includecleo workgraph plan; all five dependency outcomes agree with the independently stated oracle.Artifact: run 43807149487, built merge
9dc8657c710c57c0798ec7cff33a59c9b214b30a, SHA25600dc1587e61fe9b95e8782c1ec2f2ecd9b1b1a7fba24328c31228ae2605b22a3. Its tree is identical to source head0cbbe7b1a. Final head646fdd48ediffers only in the loader test; production source is identical, and the governor accepts the build without changing stamps. Only validated generatedpackages/*/distdirectories were staged in ignored worktree output; native artifacts and the global installation are unchanged.CI 43807149487 failed only the old archive-toggle assertion, which required deleting a hidden prerequisite edge. The corrected test retains node hiding and separately checks hidden/visible edge rendering while preserving dependency evidence; the whole file now passes 20/20. This correction makes no production change and relaxes no guard. All other applicable checks passed in that run; final-head CI is linked above.
An import audit over the nine owned production files finds three added runtime imports. They terminate in the shared policy leaf, directly or through the pure adapter; the leaf has no runtime imports and the adapter's loader reference is type-only. No new module-import cycle is introduced by these edges. Runtime-call discovery remains partial.
Typed gate:
cleo verify T12293 --run --req REQ-CROSS-EPIC-READINESS→ 39/39 passed, exit 0, freshly executed and cached for exact final head646fdd48ece0e12e7e816dc1525dc6fd3679afde. Together with the six changed files, 163 targeted tests passed across seven individual-file executions for this round. No author review or task completion is implied by the test cache.cleo done --from-merge 2953 --dry-runexits 0, recognizes AC1–AC7, and leaves the task waiting for independent verdicts on final head646fdd48e. Task closure and merge remain with the reviewer/merge workflow. Original installed/source evidence remains in T12293's canonicalcross-epic-readiness-paritynote and attached readiness checkpoints.Final-head CI snapshot
Run 43809726478, head
646fdd48ece0e12e7e816dc1525dc6fd3679afde: all applicable required jobs passed, including all eight unit shards.Conditional native/release jobs were skipped by CI. Studio verification uses the real SQL loader and pure GraphTab/adapter exports; a live browser session was not exercised. Full local build/suite/typecheck remain skipped per worker policy.