You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Use monotonic time for in-cluster token refresh - #2771
Use a monotonic clock for the one-minute projected service-account token re-read deadline in both in-cluster config loaders. Backward wall-clock changes can otherwise delay token re-reads and cause authentication failures.
Special notes for your reviewer:
All 24 sync and async in-cluster config tests passed locally. The updated tests verify that the cached token is used before the deadline and the rotated token is picked up at the deadline.
Does this PR introduce a user-facing change?
Backward wall-clock changes no longer delay service-account token refresh in the synchronous or asynchronous in-cluster client.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
This pull-request has been approved by: Sajal-ui Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Details
Needs approval from an approver in each of these files:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cncf-cla: noIndicates the PR's author has not signed the CNCF CLA.kind/bugCategorizes issue or PR as related to a bug.release-noteDenotes a PR that will be considered when it comes time to generate release notes.size/MDenotes a PR that changes 30-99 lines, ignoring generated files.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Use a monotonic clock for the one-minute projected service-account token re-read deadline in both in-cluster config loaders. Backward wall-clock changes can otherwise delay token re-reads and cause authentication failures.
Special notes for your reviewer:
All 24 sync and async in-cluster config tests passed locally. The updated tests verify that the cached token is used before the deadline and the rotated token is picked up at the deadline.
Does this PR introduce a user-facing change?