Skip to content

fix: resolve production reviewer from current user #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyson-dev merged 1 commit into from
Aug 24, 2026
Merged

fix: resolve production reviewer from current user #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/github/configure.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ gh variable set GCP_APPLY_SERVICE_ACCOUNT --repo "$repo" --env "$environment" --
gh variable set GCP_DEPLOY_SERVICE_ACCOUNT --repo "$repo" --env "$environment" --body "$deploy_sa"

if [[ "$environment" == "production" ]]; then
reviewer_id="$(gh api "users/kysonzou" --jq '.id')"
reviewer_id="$(gh api user --jq '.id')"
jq -n --argjson reviewer_id "$reviewer_id" '{
wait_timer: 0,
prevent_self_review: false,
Expand Down
1 change: 1 addition & 0 deletions scripts/github/test-tools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ printf '%s\n' '#!/usr/bin/env bash' 'set -euo pipefail' \
'fi' \
'if [[ "$1" == "api" && "$*" == *"environments/development/variables"* ]]; then printf '\''{"variables":[{"name":"GCP_APPLY_SERVICE_ACCOUNT","value":"apply@example.iam.gserviceaccount.com"},{"name":"GCP_DEPLOY_SERVICE_ACCOUNT","value":"deploy@example.iam.gserviceaccount.com"}]}\n'\''; exit 0; fi' \
'if [[ "$1" == "api" && "$*" == *"environments/development/secrets"* ]]; then printf '\''{"secrets":[{"name":"REALITY_PRIVATE_KEY"},{"name":"OBFS_PASSWORD"},{"name":"HY2_CERT_PEM"},{"name":"HY2_KEY_PEM"},{"name":"PROXY_USERS_JSON"}]}\n'\''; exit 0; fi' \
'if [[ "$1" == "api" && "$2" == "user" && "$*" == *"--jq .id"* ]]; then printf '\''123456\n'\''; exit 0; fi' \
'if [[ "$1" == "api" && "$*" == *"repos/kyson-dev/proxy-builder"* && "$*" == *"--jq .id"* ]]; then printf '\''986343343\n'\''; exit 0; fi' \
'if [[ "$1" == "api" && "$*" == *"environments/development"* && "$*" != *"--method DELETE"* ]]; then printf '\''{}\n'\''; exit 0; fi' \
'if [[ "$1 $2" == "secret set" ]]; then cat >/dev/null; exit 0; fi' >"${fake_bin}/gh"
Expand Down