Skip to content

Failing in "deno deploy" #6

Description

@justinmchase

Here is the error log:

{} TypeError: Cannot read properties of undefined (reading 'query') at githubApiUrl (https://deno.land/x/github_app_auth@v0.1.4/request.ts:7:48) at appRequest (https://deno.land/x/github_app_auth@v0.1.4/request.ts:15:26) at createInstallationToken (https://deno.land/x/github_app_auth@v0.1.4/request.ts:32:12) at GithubService.token (file:///src/src/services/github.service.ts:22:34) at async GithubService.createCheckRun (file:///src/src/services/github.service.ts:52:23) at async WebhookController.handleCheckSuite (file:///src/src/controllers/webhook.controller.ts:171:17) at async WebhookController.handler (file:///src/src/controllers/webhook.controller.ts:51:21) at async file:///src/src/controllers/webhook.controller.ts:19:53 at async dispatch (https://deno.land/x/oak@v10.2.0/middleware.ts:16:13) at async dispatch (https://deno.land/x/oak@v10.2.0/middleware.ts:16:13)

Which I believe is actually this line:
https://deno.land/x/github_app_auth@v0.1.4/request.ts#L5

Running it locally works fine with Deno 1.18.2...

I'm not totally sure but it seems like Deno.permissions must not exist and that they have a funky version of Deno running up there which is maybe not quite the latest version.

Your code looks fine for the latest version according to the docs...

Perhaps we can add a check for the permissions object itself? And default to "true" if not? Kind of a pain for now.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions