chore: replace deprecated LDClient.init() with timeout variant#38
Draft
kinyoklion wants to merge 1 commit into
Draft
chore: replace deprecated LDClient.init() with timeout variant#38kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
The no-timeout overload of LDClient.init() was deprecated in SDK 5.2.0. Use init(Application, LDConfig, LDContext, int) with a 5-second timeout. Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LDClient.init(Application, LDConfig, LDContext)(no timeout) was deprecated in SDK 5.2.0. Replaced with the timeout overload:Uses a 5-second startup wait, consistent with the SDK's recommended usage pattern. The SDK version (5.13.1) is already at the latest stable release — no dependency bump needed.
Link to Devin session: https://app.devin.ai/sessions/ade60c53c28c4ebaa7f9ad394c3dcd9d
Requested by: @kinyoklion