Skip to content

feat: Require PHP 8.2 or later - #32

Merged
jsonbailey merged 5 commits into
mainfrom
jb/sdk-3350/windows-php-pins
Oct 21, 2026
Merged

jsonbailey merged 5 commits into
mainfrom
jb/sdk-3350/windows-php-pins

Conversation

@jsonbailey

@jsonbailey jsonbailey commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

PHP 8.1 is end-of-life. The minimum PHP version is now 8.2.

  • composer.json requires php >=8.2.
  • CI tests PHP 8.2 to 8.4. Windows CI uses shivammathur/setup-php with minor versions, so patch releases (including the CVE-2026-109618/109619 fixes) need no manual pins.
  • Fix the Linux CI matrix key (php-versions -> php-version). Linux jobs always ran the default PHP before.
  • README states the new minimum.

Note

Overview
Raises the minimum supported PHP version from 8.2 (replacing 8.1) in composer.json, README examples, and the shared CI action default.

CI now runs tests on 8.2, 8.3, and 8.4 on Linux and Windows. The Linux workflow matrix key is fixed from php-versions to php-version so matrix values are actually passed to the composite action instead of always using the default. On Windows, Chocolatey PHP/composer installs are replaced with shivammathur/setup-php, matching Linux and avoiding pinned patch versions.

Reviewed by Cursor Bugbot for commit 1378287. Bugbot is set up for automated code reviews on this repo. Configure here.

@jsonbailey jsonbailey changed the title chore: Update Windows CI PHP versions chore: Align Windows CI PHP setup with the server SDK Oct 21, 2026
@jsonbailey
jsonbailey marked this pull request as ready for review October 21, 2026 17:15
@jsonbailey
jsonbailey requested a review from a team as a code owner October 21, 2026 17:15
@jsonbailey jsonbailey changed the title chore: Align Windows CI PHP setup with the server SDK feat: Require PHP 8.2 or later Oct 21, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2c46d86. Configure here.

Comment thread .github/workflows/ci.yml Outdated
@jsonbailey
jsonbailey merged commit 50c99d1 into main Oct 21, 2026
13 checks passed
@jsonbailey
jsonbailey deleted the jb/sdk-3350/windows-php-pins branch October 21, 2026 18:35
jsonbailey pushed a commit that referenced this pull request Oct 21, 2026
🤖 I have created a release *beep* *boop*
---


##
[2.0.0](1.0.0...2.0.0)
(2026-10-21)


### ⚠ BREAKING CHANGES

* Do not add the targeting key as a custom attribute
([#28](#28))

### Features

* Require PHP 8.2 or later
([#32](#32))
([50c99d1](50c99d1))


### Bug Fixes

* Do not add the targeting key as a custom attribute
([#28](#28))
([2fb07d1](2fb07d1))
* Map the WRONG_TYPE error kind to TYPE_MISMATCH
([#27](#27))
([481eb3c](481eb3c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Overview**
> **Release 2.0.0** — bumps the package from `1.0.0` to `2.0.0` across
Release Please manifest, `Provider::VERSION`, docs build title, and
**CHANGELOG**.
> 
> This cut documents **breaking** behavior: the provider no longer
copies the OpenFeature **targeting key** into LaunchDarkly custom
attributes (only the LD context key). It also raises the minimum runtime
to **PHP 8.2+** and notes a fix mapping LaunchDarkly **WRONG_TYPE**
evaluations to OpenFeature **`TYPE_MISMATCH`** (already reflected in
current `Provider` / converter code).
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
5883fcd. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants