feat(AIC-3230): emit evaluation context identity - #65
Merged
Conversation
added 6 commits
September 3, 2026 14:21
andrewklatzke
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
uv run pytest(1,155 passed, 11 skipped)Ran locally and confirmed data went to staging w/ events containing context values.
Note
Overview
Adds evaluation context identity to root OpenTelemetry spans when
variables.ldContexthas a usable identity, read separately fromTrackData.set_ld_span_attributesnow derives a canonical context id (with%/:escaping for multi-kind contexts) and per-kind raw keys, writingcontext.contextKeys.<kind>on the root span andfeature_flag.context.id/feature_flag.contextKeyson the existingfeature_flagevent. Malformed or missing context omits these fields and never raises; only context keys are emitted, not other context attributes.AGENTS.md and TELEMETRY-CONTRACT.md document the new contract. Examples use a new
new_multi_context()helper (org key with%/:) and log context to stderr; the judge example fixes handler registration viaexamples.register. Tests cover identity edge cases, cross-handler root-only placement, vocabulary lock, and example utils; pytest getspythonpath = ["."]for discovery.Reviewed by Cursor Bugbot for commit a371de8. Bugbot is set up for automated code reviews on this repo. Configure here.