Repository navigation
chore: Remove copied SDK dependencies from the docs group - #218
Open
jsonbailey wants to merge 3 commits into
Open
jsonbailey wants to merge 3 commits into
jsonbailey wants to merge 3 commits into
Conversation
jsonbailey
marked this pull request as ready for review
October 21, 2026 14:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs dependency group repeated launchdarkly-server-sdk's own dependencies (certifi, expiringdict, pyrfc3339, jsonpickle, semver, urllib3).
The package never imports them and gets them through the launchdarkly-server-sdk requirement. jsonpickle is only used by one SDK test and is not required by the SDK at runtime.
Docs still build (CI runs make docs).
Removes the unused poetry.lock, since the build uses uv.
Adds poetry.lock to .gitignore so a stale local lock file is not committed again.
Note
Overview
Trims the
server-aidocs dependency group so it only lists Sphinx, the RTD theme, and pinnedjinja2, removing packages that duplicatedlaunchdarkly-server-sdktransitives (andjsonpickle, which isn’t needed for docs or runtime).Drops
packages/sdk/server-ai/poetry.lockand ignorespoetry.lockrepo-wide, matching the existing uv-based workflow (uv sync --group docsfor docs) so Poetry lockfiles aren’t committed again.Reviewed by Cursor Bugbot for commit 6782a50. Bugbot is set up for automated code reviews on this repo. Configure here.