[CI] Correct misleading check-deps message for hugo binary - #1250
ayanasarkar wants to merge 1 commit into
Conversation
…5io#1211) Signed-off-by: Ayana Sarkar <ayanasarkar.tech@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ChangesDependency check messaging
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other · Severity of issue fixed: Low Suggested reviewers: Merge Risk: ⚪ Minimal · up to This update only clarifies developer-facing setup guidance and introduces no runtime behavior change. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Notes for Reviewers
This PR fixes #1211
The
check-depstarget's underlying checks were already correct — it verifiesnpmis on the PATH and that the Hugo binary exists atnode_modules/.bin/hugo(installed viamake setup), not a separately, system-wide installed Hugo. The echo message said "local 'hugo' binary," which implied the opposite. This PR updates the message text only — no logic changes.Signed commits
Summary by CodeRabbit
node_modulesby the setup process.