Skip to content

[CI] Correct misleading check-deps message for hugo binary - #1250

Open
ayanasarkar wants to merge 1 commit into
layer5io:masterfrom
ayanasarkar:fix/check-deps-message-1211
Open

ayanasarkar wants to merge 1 commit into
layer5io:masterfrom
ayanasarkar:fix/check-deps-message-1211

Conversation

@ayanasarkar

@ayanasarkar ayanasarkar commented Sep 17, 2026

Copy link
Copy Markdown

Notes for Reviewers

This PR fixes #1211

The check-deps target's underlying checks were already correct — it verifies npm is on the PATH and that the Hugo binary exists at node_modules/.bin/hugo (installed via make setup), not a separately, system-wide installed Hugo. The echo message said "local 'hugo' binary," which implied the opposite. This PR updates the message text only — no logic changes.

Signed commits

  • Yes, I signed my commits.

Summary by CodeRabbit

  • Documentation
    • Updated setup guidance to clarify that the Hugo binary is expected to be installed within node_modules by the setup process.

…5io#1211)

Signed-off-by: Ayana Sarkar <ayanasarkar.tech@gmail.com>
@welcome

welcome Bot commented Sep 17, 2026

Copy link
Copy Markdown

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 6666ca63-65f6-4784-92c2-b840e220a600

📥 Commits

Reviewing files that changed from the base of the PR and between 9ab0b6b and 5e3ca4b.

📒 Files selected for processing (1)
  • Makefile

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The check-deps message now states that Hugo is provided through node_modules and installed by make setup, instead of referring to a local Hugo binary.

Changes

Dependency check messaging

Layer / File(s) Summary
Update dependency check message
Makefile
The check-deps target now describes the npm-packaged Hugo binary and its installation through make setup.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other · Severity of issue fixed: Low

Suggested reviewers: sbragul26

Merge Risk: ⚪ Minimal · up to 5e3ca

This update only clarifies developer-facing setup guidance and introduces no runtime behavior change.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: correcting the misleading check-deps message for the Hugo binary.
Linked Issues check ✅ Passed Issue #1211 requires an accurate check-deps message. The pull request changes the Makefile message to state that Hugo is expected in node_modules and installed by make setup. This removes the …
Out of Scope Changes check ✅ Passed The summary reports one message-only change in Makefile. The change directly supports issue #1211 and introduces no unrelated logic or file changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Makefile: Misleading message for check-deps

1 participant