fix: resolve <linearGradient> -nan attributes and SRL context errors - #8049
tejaswiverma121-byte wants to merge 1 commit into
Conversation
- Fix invalid -nan attributes in solutions-cost.svg by replacing with valid line coordinates - Wrap application with SimpleReactLightbox at root level in root-wrapper.js to provide global lightbox context - Add standard SEO Head export to orchestration-management page Fixes layer5io#8048 Signed-off-by: tejaswiverma <tejaswiverma121@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe root wrapper now provides SimpleReactLightbox context around rendered MDX content. The orchestration management page now exports SEO metadata through a Head component. ChangesLightbox Context
Orchestration Management SEO
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to The lightbox, SVG, and SEO changes have no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation Issue Full details: Out of Scope Changes checkExplanation The new
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment for PR #8049 removed. This PR preview was automatically pruned because we keep only the 3 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
dhruveshmishra
left a comment
There was a problem hiding this comment.
thanks for replacing the -nan coords — can you confirm the gradient coordinates match the SVG viewBox at different sizes and that there are no other SVGs with -nan attributes? If possible provide a screenrecording for that
Yes, confirmed on both points.. @dhruveshmishra
ViewBox & Scaling: The SVG defines viewBox="0 0 528 372". The stroked path runs from (28.0469, 328.661) to (503.776, 328.661). Because gradientUnits="userSpaceOnUse" operates in the coordinate space established by the SVG's viewBox (the same pattern used by paint0 through paint26 in this file), the gradient scales proportionally and stays aligned to the path across all screen widths. Repository Scan: Ran git grep -i -- "-nan" and scanned all SVGs across the project; solutions-cost.svg was the only file containing "-nan" attributes, and there are 0 remaining occurrences.
|
|
Hey could you add this as an agenda item for websites meet on Monday, we could discuss it there, you can find the link to the meeting minutes in the #websites channel on Slack. |




Fixes #8048
Description
This PR fixes #8048
This PR resolves the console errors and warnings logged when viewing
/solutions/orchestration-managementand related solutions pages:x1="-nan" y1="-nan" x2="-nan" y2="-nan"attributes insrc/sections/Solutions/images/solutions-cost.svgwith valid coordinatesx1="28.0469" y1="328.661" x2="503.776" y2="328.661"matching the stroke pathM28.0469 328.661H503.776.root-wrapper.jswith<SimpleReactLightbox>, ensuring that any component mounting<SRLWrapper>(or during client-side route transitions) always has access to the lightbox context.Headexport withSEOmetadata component insrc/pages/solutions/orchestration-management/index.js.Testing & Verification
http://localhost:8000/solutions/orchestration-management).<linearGradient> attribute: Expected length, "-nan"andSRL - ERROR WHEN RESETTING THE LIGHTBOX STATUSare no longer logged.Notes for Reviewers
Signed commits
Summary by CodeRabbit
New Features
Improvements