fix: restore missing caret icon on WorkspaceEnvironmentSelection drop…

[vijyotsilare]

Description

Fixes the missing dropdown caret icon on the "Assigned Environment" selector in the Workspaces section (playground.meshery.io/management/workspaces). Every other dropdown in the UI shows a caret on the right side to indicate it's an expandable Autocomplete field; this one was silently missing it.

Root Cause

WorkspaceEnvironmentSelection.tsx explicitly set popupIcon={null} on the MUI Autocomplete component, which unconditionally suppresses the default dropdown arrow icon. There was no conditional logic around it — it simply hid the icon in all cases.

Fix

Removed the popupIcon={null} prop, allowing the Autocomplete's default caret icon to render as expected, consistent with every other dropdown in the app.

Testing

• Reproduced the bug locally against a full Meshery dev build (meshery/meshery, branch fix/assigned-environment-caret-icon, used only for verification — no code changes there).
• Confirmed the caret was missing before the fix and visually confirmed it now renders correctly after the fix, on localhost:3000 (Next.js dev build).
• No other dropdown behavior was affected; this is a single-prop removal with no logic changes.

Screenshots

Before:

After:

Related Issue

Fixes meshery/meshery#21674

Summary by CodeRabbit

• UI Improvements
  • Restored the dropdown indicator icon in workspace environment selection.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 23bf545f-96a0-48de-b547-c27ea9ee261d

📥 Commits

Reviewing files that changed from the base of the PR and between 53f1329 and 92c5ab9.

📒 Files selected for processing (1)

• src/custom/Workspaces/WorkspaceEnvironmentSelection.tsx

💤 Files with no reviewable changes (1)

• src/custom/Workspaces/WorkspaceEnvironmentSelection.tsx

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

The Workspace environment selector no longer suppresses the Autocomplete dropdown icon. The default caret is now visible.

Changes

Workspace environment selector

Layer / File(s)	Summary
Restore dropdown caret src/custom/Workspaces/WorkspaceEnvironmentSelection.tsx	Removed popupIcon={null} from the Autocomplete component. The default dropdown caret now renders.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 92c5a

The Assigned Environment selector restores its standard dropdown caret, with no remaining merge-readiness risk identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the primary change: restoring the missing caret icon in the Workspace Environment selector.
Linked Issues check	✅ Passed	The change removes popupIcon={null} from the MUI Autocomplete, which restores the default dropdown caret required by issue #21674.
Out of Scope Changes check	✅ Passed	The pull request changes only the relevant Autocomplete prop. No unrelated code changes are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[hiyach28]

lgtm!

[vedant21-ctr]

LGTM !

[hiyach28]

Thank you for your contribution!
Let’s discuss this during tomorrow’s website call at 5:30 PM IST / 6 AM CT.
If you would, please add it as an agenda item to the meeting minutes :)

[hiyach28]

removing popupIcon={null} fixes the root cause, the Assigned Environment selector now shows the same default dropdown arrow as the other selectors. The other components that set popupIcon={null} (InputSearchField, UserSearchFieldInput) are search fields where hiding the arrow is intentional, so nothing similar is left to fix. CI is green.
LGTM 🚀