fix: sign container images by digest in release workflows - #6
Merged
Merged
Conversation
Sign the pushed images with keyless cosign (GitHub OIDC) after push, and document how to verify them. Closes #5 Claude-Session: https://claude.ai/code/session_01F31tj4MqKr67gzt3awyM4m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
The release workflows pushed images without signing them. This adds keyless cosign signing (GitHub OIDC,
id-token: write) of each pushed image by digest inrelease.yml(router, TEI base and runtime) andrelease-models.yml(model init images, whisper), via a smallscripts/sign-image.sh, and documentscosign verifywith the exact workflow identity.Verification happens after merge: a release build must produce an image whose digest passes
cosign verify.https://claude.ai/code/session_01F31tj4MqKr67gzt3awyM4m