Repository navigation
Conversation
Remove the redundant "@php vendor/bin/" prefix from script definitions. Composer automatically includes the vendor binary directory in the PATH, making the explicit path unnecessary and the config cleaner.
There was a problem hiding this comment.
馃煝 Approval recommended
No unresolved issues were identified, and existing commands are preserved.
Pull request overview
Refactors composer.json scripts to invoke alchemy directly instead of using explicit @php vendor/bin/ paths.
Changes:
- Simplifies Alchemy script commands.
- Preserves existing script names and targets.
File summaries
| File | Summary |
|---|---|
composer.json |
Simplifies Composer script command definitions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mychidarko
left a comment
mychidarko
left a comment
There was a problem hiding this comment.
I'd keep these as they are. Alchemy generates exactly @php vendor/bin/alchemy ... for these scripts (Core::installComposerScripts) and rewrites them on its next setup run, so this change would just get reverted. The explicit @php form also runs the script with the same PHP binary as Composer, which the bare alchemy call doesn't guarantee.
|
Thanks for this! Closing it though: these |
What kind of change does this PR introduce? (pls check at least one)
Description
This pull request updates the
composer.jsonfile to simplify how project scripts are executed. The change removes the explicit@php vendor/bin/path from all script commands, replacing it with just the command name. This makes the scripts easier to run and more portable, assuming thealchemyexecutable is available in the system path.composer.jsonto use thealchemycommand directly instead of prefixing with@php vendor/bin/.Does this PR introduce a breaking change? (check one)