Migrate to php82 with rector by fadrian06 · Pull Request #64 · leafsphp/auth

fadrian06 · 2026-10-21T02:21:22Z

What kind of change does this PR introduce? (pls check at least one)

Description

➜ php -a                                                                                                                                            
Interactive shell                                                                                                                                   

php > use Leaf\App;                                                                                                                                 php > var_dump(class_exists(App::class));                                                                                                           php shell code:1:                                                                                                                                   
bool(false)                                                                                                                                         
php > use Leaf\Billing\Tier;                                                                                                                        php > $tier = $subscription['tier'] ?? null;                                                                                                        php > var_dump($tier instanceof Tier);                                                                                                              php shell code:1:                                                                                                                                   
bool(false)                                                                                                                                         
php > foreach ([] as $item) {}

All refactors were tested in interactive shell.

Does this PR introduce a breaking change? (check one)

Yes
No

Replace hardcoded class strings and fully qualified names with ::class syntax and add missing use statements. This improves maintainability and enables better static analysis and IDE support.

Replace the manual isset check and assignment with the null coalescing assignment operator. This change simplifies the logic and improves code readability by using modern PHP syntax.

Update the array_map call to use the first-class callable syntax introduced in PHP 8.1. This improves code readability and allows for better static analysis compared to using string-based callbacks.

Implement the Stringable interface and add a string return type hint to the __toString method. This ensures compatibility with PHP 8.0+ and explicitly defines the class's string representation behavior.

Update catch statements to use non-capturing catches. This removes unused variables where the exception object is not required for the error handling logic, following PHP 8.0+ syntax.

Replace traditional anonymous functions with arrow functions in the UsesRoles trait and auth helper. This modernization reduces code verbosity and improves readability for simple return statements.

Simplify the return statement in the subscription method by using the shorthand ternary operator (?:). This change removes the redundant reference to the subscription property, making the code cleaner and more concise.

Update the table creation logic to use a match expression instead of a switch statement. This modernizes the code using PHP 8 features and improves readability by removing redundant break statements.

Remove setAccessible(true) calls from ReflectionProperty instances in google.test.php and roles.test.php. These calls are no longer required in modern PHP versions, and removing them simplifies the test code.

…ions Add the dead-code rule set to alchemy configuration to improve code quality and maintainability. Remove explicit null assignments from class properties in Auth and UsesSubscriptions because they are redundant in PHP and flagged as dead code.

@return

Remove redundant @return and @PARAM tags from PHPDoc blocks across the codebase. These tags are unnecessary because the methods already use native PHP type hints. This cleanup reduces documentation noise and improves maintainability.

Remove the explicit count check before iterating over hidden fields. PHP's foreach handles empty arrays natively, making the check unnecessary. This simplifies the logic and reduces nesting levels.

Remove the try-catch block that only re-throws exceptions to simplify the code and allow the test runner to handle errors naturally.

Remove the empty __construct method from the FakeBillingDriver class to clean up the test mock as it performs no initialization logic.

Remove the try-catch block in the beforeAll hook that was simply rethrowing exceptions. This simplifies the database initialization logic for tests without changing the error handling behavior.

Remove the unused $testUser variable from the logout closure in tests/user.test.php to clean up the test code and avoid unnecessary variable capturing.

Delete the phpstan-baseline.neon file to enforce stricter static analysis. This ensures that type errors in Auth.php and User.php are no longer ignored, promoting better code quality and type safety.

Ensure consistent formatting by adding a space after the fn keyword in arrow functions. This aligns the code with PSR-12 standards and improves overall code style consistency.

Create phpstan-baseline.neon to ignore existing static analysis errors. This ensures that future static analysis runs only report new issues.

fadrian06 added 19 commits September 10, 2026 23:10

refactor: use ::class constants and import namespaces

b66b92f

Replace hardcoded class strings and fully qualified names with ::class syntax and add missing use statements. This improves maintainability and enables better static analysis and IDE support.

refactor(auth): use null coalescing assignment for redirectUri

44c0ac0

Replace the manual isset check and assignment with the null coalescing assignment operator. This change simplifies the logic and improves code readability by using modern PHP syntax.

refactor(auth): use first-class callable syntax for ucwords

3039275

Update the array_map call to use the first-class callable syntax introduced in PHP 8.1. This improves code readability and allows for better static analysis compared to using string-based callbacks.

refactor(auth): implement Stringable interface in User class

442f8ba

Implement the Stringable interface and add a string return type hint to the __toString method. This ensures compatibility with PHP 8.0+ and explicitly defines the class's string representation behavior.

refactor: remove unused exception variables in catch blocks

23d11f3

Update catch statements to use non-capturing catches. This removes unused variables where the exception object is not required for the error handling logic, following PHP 8.0+ syntax.

refactor: use arrow functions for concise closure syntax

f58fa30

Replace traditional anonymous functions with arrow functions in the UsesRoles trait and auth helper. This modernization reduces code verbosity and improves readability for simple return statements.

refactor(tests): replace switch with match in createTableForUsers

96a9855

Update the table creation logic to use a match expression instead of a switch statement. This modernizes the code using PHP 8 features and improves readability by removing redundant break statements.

test: remove redundant setAccessible calls in reflection tests

588a018

Remove setAccessible(true) calls from ReflectionProperty instances in google.test.php and roles.test.php. These calls are no longer required in modern PHP versions, and removing them simplifies the test code.

docs: remove redundant PHPDoc tags

c332073

Remove redundant @return and @PARAM tags from PHPDoc blocks across the codebase. These tags are unnecessary because the methods already use native PHP type hints. This cleanup reduces documentation noise and improves maintainability.

refactor(auth): remove redundant count check for hidden fields

9d9f739

Remove the explicit count check before iterating over hidden fields. PHP's foreach handles empty arrays natively, making the check unnecessary. This simplifies the logic and reduces nesting levels.

test: remove redundant try-catch block in login test setup

4f2e12f

Remove the try-catch block that only re-throws exceptions to simplify the code and allow the test runner to handle errors naturally.

refactor(tests): remove unused constructor in FakeBillingDriver

a457e52

Remove the empty __construct method from the FakeBillingDriver class to clean up the test mock as it performs no initialization logic.

test: remove redundant try-catch in user test setup

f3f5f07

Remove the try-catch block in the beforeAll hook that was simply rethrowing exceptions. This simplifies the database initialization logic for tests without changing the error handling behavior.

test: remove unused variable from logout callback

db54f1d

Remove the unused $testUser variable from the logout closure in tests/user.test.php to clean up the test code and avoid unnecessary variable capturing.

chore: remove phpstan baseline

b34a0a0

Delete the phpstan-baseline.neon file to enforce stricter static analysis. This ensures that type errors in Auth.php and User.php are no longer ignored, promoting better code quality and type safety.

style: add space after fn keyword in arrow functions

9c18b7e

Ensure consistent formatting by adding a space after the fn keyword in arrow functions. This aligns the code with PSR-12 standards and improves overall code style consistency.

chore: add phpstan baseline file

b08c616

Create phpstan-baseline.neon to ignore existing static analysis errors. This ensures that future static analysis runs only report new issues.

Navigation Menu

Repository navigation

Migrate to php82 with rector - #64

Migrate to php82 with rector#64
fadrian06 wants to merge 19 commits into
leafsphp:v5.xfrom
fadrian06:migrate-to-php82-with-rector

fadrian06 commented Oct 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

fadrian06 commented Oct 21, 2026

What kind of change does this PR introduce? (pls check at least one)

Description

Does this PR introduce a breaking change? (check one)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant