fix(windows): destroy window before quitting message loop - #590
Open
Davit-Meliqyan wants to merge 2 commits into
Open
fix(windows): destroy window before quitting message loop#590Davit-Meliqyan wants to merge 2 commits into
Davit-Meliqyan wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a Windows shutdown delay when
setPreventClose(true)is enabled.Problem
windowManager.destroy()currently calls:This exits the Win32 message loop before the native window is actually destroyed.
As a result, Flutter Engine shutdown happens outside the normal window lifecycle and the process may remain alive for around 17–18 seconds before exiting.
Solution
Replace:
with:
This restores the normal Win32 shutdown sequence:
Verification
Tested on Windows 11.
Before:
setPreventClose(true)caused a ~17–18 second delay before process exit.After: