fix: select PR CI changes from the merge base - #644
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Select pull-request CI work from the PR merge base, rather than diffing the current
maintip directly against the contributor head. The direct tip-to-tip diff treated changes that landed only onmainas PR changes.PR #643 illustrates the failure: its visible diff adds only a Lean module and manifest, but its CI selector reported
.github/workflows/ci.yml,lake-manifest.json,lakefile.toml, andlean-toolchainas full-catalog sentinels. It also classified main-onlygenerated/changes as part of the PR, ran the generated-index check, and failed withstale generated/index.jsoneven though all eight catalog shards passed.Push-to-main selection remains unchanged. A regression test creates diverged branches and verifies that PR selection excludes base-only changes.
Validation
PYTHONDONTWRITEBYTECODE=1 python -m unittest discover -s tests/python -p 'test_*.py'— 36 tests passed.python -m py_compile scripts/select_ci_problems.py tests/python/test_select_ci_problems.py— passed.git diff --check— passed.