Test simulation steps across all integrators - #122
Open
Mikasa0503 wants to merge 2 commits into
Open
Mikasa0503 wants to merge 2 commits into
Mikasa0503 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Extend finiteness checks to cover the omitted state tensors.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds parameterized smoke tests covering all supported simulation integrators.
Changes:
- Tests two simulation steps for each integrator.
- Verifies step advancement and finite state tensors.
| File | Summary |
|---|---|
tests/unit/test_sim.py |
Adds integrator smoke tests; force, torque, and rotor_vel are not included in finiteness checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Mikasa0503
force-pushed
the
test/integrator-smoke-coverage
branch
from
September 20, 2026 12:49
75e533c to
b83310f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
uv run pytest -q tests/unit/test_sim.py::test_sim_step_integratorsuv run pytest -q tests/unit/test_sim.pyuv run ruff check tests/unit/test_sim.pyuv run ruff format --check tests/unit/test_sim.pyResults: 211 passed, 37 skipped, 1 deselected.
Addresses #106