Skip to content

macOS: do not require the nonactivating style bit once an owned Cocoa popup is shown #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lextm merged 1 commit into from
Oct 26, 2026
Merged

macOS: do not require the nonactivating style bit once an owned Cocoa popup is shown #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ProGPU.Backend/CocoaNativePopupWindow.OwnedSurface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,9 @@ private sealed class OwnedOperations(OwnerLease? initialOwner, nint panel, nint
GetOwnedBool(panel, "becomesKeyOnlyIfNeeded\0"u8) &&
!GetOwnedBool(panel, "isReleasedWhenClosed\0"u8) &&
!GetOwnedBool(panel, "canBecomeKeyWindow\0"u8) && !GetOwnedBool(panel, "canBecomeMainWindow\0"u8) &&
OwnedMessageUnsigned(panel, Selector("styleMask\0"u8)) == NonactivatingPanelStyle;
// AppKit reports the nonactivating bit as cleared once the panel is ordered in as a child window
// (macOS 27.0.1 and the macos-15 runner), so only reject style bits the panel was never given.
(OwnedMessageUnsigned(panel, Selector("styleMask\0"u8)) & ~NonactivatingPanelStyle) == 0;

public bool BindOwner(NativeWindowHandle owner)
{
Expand Down
Loading