Skip to content

Update populate_with_metadata for spent differentiation. #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Sep 15, 2026
Merged

Update populate_with_metadata for spent differentiation. #931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions include/bitcoin/database/impl/query/consensus/consensus_populate.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,12 @@ bool CLASS::populate_with_metadata(const input& input, bool chain,
metadata.median_time_past = max_uint32;
}

if (pool)
// The genesis coinbase is unspendable, so no confirmed spender is at
// zero, which therefore distinguishes an unconfirmed spender.
if (pool && !is_spent(input.point()))
{
// Any spender (including duplicate tx) implies spent.
const auto spent = is_spent(input.point());
metadata.spender_height = spent ? 0_u32 : max_uint32;
// Any spender (including duplicate tx) not found.
metadata.spender_height = max_uint32;
}
else if (const auto height = find_strong_spender_height(input.point());
!height.is_terminal())
Expand All @@ -135,7 +136,7 @@ bool CLASS::populate_with_metadata(const input& input, bool chain,
else
{
// Confirmed spender not found.
metadata.spender_height = max_uint32;
metadata.spender_height = pool ? 0_u32 : max_uint32;
}
}

Expand Down
24 changes: 18 additions & 6 deletions test/query/archive/chain_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,7 @@ BOOST_AUTO_TEST_CASE(query_chain_reader__populate_with_metadata__metadata__expec
BOOST_CHECK_EQUAL(tx4.inputs_ptr()->at(1)->metadata.parent_tx, 1u);
}

// A free tx cannot conflict, so any spender of its prevout implies spent.
// A free tx conflicts with any spender, but only a confirmed one has height.
BOOST_AUTO_TEST_CASE(query_chain_reader__populate_with_metadata__pool_spender__expected)
{
settings settings{};
Expand All @@ -861,23 +861,35 @@ BOOST_AUTO_TEST_CASE(query_chain_reader__populate_with_metadata__pool_spender__e
test::query_accessor query{ store };
BOOST_CHECK(!store.create(test::events_handler));
BOOST_CHECK(query.initialize(test::genesis));
BOOST_CHECK(query.set(test::block1a, test::context, false, false));
BOOST_CHECK(query.set(test::block1a, context{ 0, 1, 0 }, false, false));

// tx5 spends the first output of the first tx of block1a, as does tx4.
// tx5 spends the first output of the first tx of block1a, as do tx4 and
// the first transaction of block2a.
const auto& unspent = clean_(test::tx5);
BOOST_CHECK(query.populate_with_metadata(unspent, true, true));
BOOST_CHECK_EQUAL(unspent.inputs_ptr()->at(0)->metadata.spender_height, max_uint32);

BOOST_CHECK(query.set(test::tx4));

const auto& spent = clean_(test::tx5);
BOOST_CHECK(query.populate_with_metadata(spent, true, true));
BOOST_CHECK_EQUAL(spent.inputs_ptr()->at(0)->metadata.spender_height, 0u);
const auto& pooled = clean_(test::tx5);
BOOST_CHECK(query.populate_with_metadata(pooled, true, true));
BOOST_CHECK_EQUAL(pooled.inputs_ptr()->at(0)->metadata.spender_height, 0u);

// The spender is unassociated, so it is not a confirmed spender.
const auto& chained = clean_(test::tx5);
BOOST_CHECK(query.populate_with_metadata(chained, true, false));
BOOST_CHECK_EQUAL(chained.inputs_ptr()->at(0)->metadata.spender_height, max_uint32);

BOOST_CHECK(query.set(test::block2a, context{ 0, 2, 0 }, false, false));
BOOST_CHECK(query.set_strong(2));

const auto& confirmed = clean_(test::tx5);
BOOST_CHECK(query.populate_with_metadata(confirmed, true, true));
BOOST_CHECK_EQUAL(confirmed.inputs_ptr()->at(0)->metadata.spender_height, 2u);

const auto& strong = clean_(test::tx5);
BOOST_CHECK(query.populate_with_metadata(strong, true, false));
BOOST_CHECK_EQUAL(strong.inputs_ptr()->at(0)->metadata.spender_height, 2u);
}

// populate_without_metadata
Expand Down
Loading