Repository navigation
Size singleton bitcoind json-rpc and stream http responses. - #1149
Closed
eynhaender wants to merge 1 commit into
Closed
eynhaender wants to merge 1 commit into
eynhaender wants to merge 1 commit into
Conversation
Every http json-rpc response was sent with chunked transfer coding, which is conformant for http/1.1 (rfc9112 6.1). bitcoind never chunks, and some of its clients (e.g. fulcrum) reject a response without content-length, contrary to rfc9112. To tolerate them, a non-batch response is serialized up front and sent with content-length. Batch responses remain chunked. A stream response has a known size and is now sent with content-length instead of chunked.
Member
|
Added this to the backlog as a maybe, but I'm not convinced it's a good idea to allow bad clients to break our spec and perf, especially if the example is Fulcrum, which would never be synced against bs. Also the implementation needs to vary from this, so closing for now. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every http json-rpc response was sent with chunked transfer coding, which is conformant for http/1.1 (rfc9112 6.1). bitcoind never chunks, and some of its clients (e.g. fulcrum) reject a response without content-length, contrary to rfc9112. To tolerate them, a non-batch response is serialized up front and sent with content-length. Batch responses remain chunked.
A stream response has a known size and is now sent with content-length instead of chunked.