Skip to content

Fix malformed sha tag - #1318

Merged
COM8 merged 2 commits into
libcpr:masterfrom
mbKaleb:fix-malformed-sha-tag
Aug 28, 2026
Merged

COM8 merged 2 commits into
libcpr:masterfrom
mbKaleb:fix-malformed-sha-tag

Conversation

@mbKaleb

@mbKaleb mbKaleb commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Fixes #1317

Changes:

  • README.md: drops the .12.0 so the snippet pins the bare commit SHA.
  • readme-updater.yml: change the pattern to (GIT_TAG) [^ )]+ so it
    replaces the whole token whatever its shape (SHA or dotted version) and
    stops at the closing paren. This should prevent partial-match leftovers

Verified the new expression against both historical shapes — GIT_TAG 1.12.0)
and GIT_TAG f091…79d.12.0) each come out as GIT_TAG <new-sha>).

@COM8 COM8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@COM8
COM8 merged commit 83cf8cc into libcpr:master Aug 28, 2026
32 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unneeded characters in CMake chapter

2 participants