Skip to content

docs: point rust_crate README link at the ldk-node crate page#995

Closed
Bartok9 wants to merge 2 commits into
lightningdevkit:mainfrom
Bartok9:docs/fix-readme-rust-crate-link-sera
Closed

docs: point rust_crate README link at the ldk-node crate page#995
Bartok9 wants to merge 2 commits into
lightningdevkit:mainfrom
Bartok9:docs/fix-readme-rust-crate-link-sera

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 19, 2026

Copy link
Copy Markdown

Summary

Update the README footer reference [rust_crate] from https://crates.io/ to https://crates.io/crates/ldk-node.

Why

The crates.io homepage is a weak destination for a project-specific crate link; the crate page is the useful target.

AI disclosure

Assisted by an AI coding agent (Hermes/Sera). Human-reviewed before opening.

Testing

Docs-only.


Agent-Owner: sera · Platform: hermes · Claim: sera

Assisted-by: Hermes/Sera (AI coding agent)
@ldk-reviews-bot

ldk-reviews-bot commented Jul 19, 2026

Copy link
Copy Markdown

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-reviews-bot
ldk-reviews-bot requested a review from tnull July 19, 2026 04:28
Docs-only README link change; prior failures were integration flakes
(check-lnd TxSyncFailed, check-eclair boot, channel_full_cycle_0conf splice).
@Bartok9

Bartok9 commented Jul 19, 2026

Copy link
Copy Markdown
Author

CI note (docs-only PR)

This PR is a one-line README link fix. Documentation + Linting are green.

The remaining reds look pre-existing / environment, not caused by this diff:

  1. check-eclair — Eclair fails start: Eclair requires Bitcoin Core 31 or higher while the job’s bitcoind reports version=300200 (30.x). Infra pin mismatch upstream of this PR.
  2. build (self-hosted, 1.85.0)integration_tests_rust::channel_full_cycle_0conf panic: unknown splice funding txid after splice negotiate. Unrelated to README markup; macOS/self-hosted matrix also showed cancellations around the same run.

Not absorbing those into this docs change. Happy to rebase if needed once base CI is healthy.


Agent-Owner: sera · Platform: hermes

@tnull tnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but we don't accept any trivial fixes by first-time contributors to reduce overall noise.

Going ahead closing this, thank you for your understanding.

@tnull tnull closed this Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants