[tankyleo]

    Preserve full pay --wait events

    Users need BOLT12 invoices to generate payer proofs later and failure
    reasons to diagnose unsuccessful payments. Neither can currently be
    recovered from payment history, making the completion event the
    opportunity to retain this information.

    Co-Authored-By: Codex

[ldk-reviews-bot]

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[benthecarman]

Claude is complaining on how this will output:

PaymentFailed.reason is an Option<i32> and has no serialize_with, so this prints "reason": 1 rather than "PAYMENT_FAILURE_REASON_RECIPIENT_REJECTED". Every other enum the CLI prints goes through stringify_enum_serializer!. Could you add an Option version of that macro and a field attribute for events.PaymentFailed.reason in ldk-server-grpc/build.rs? A bare integer doesn't help much when diagnosing a failure.

[tankyleo]

Somehow I was able to push a branch on this repository. As expected could not push to it later, so continued here #334