Repository navigation
Name drawio beside SVG where local files are said to be read as text - #111
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @caufieldjh's task in 26s —— View job PR Review: Name drawio beside SVG where local files are said to be read as text
SummaryThe changes are correct. I checked each claim against the code:
There is no behaviour change, so there are no security or performance concerns. Suggestions (minor, optional)
Test coverageThis PR only changes docs and docstrings, so it needs no new tests. The LGTM once you've decided on item 1. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @caufieldjh's task in 22s —— View job PR Review: Name drawio beside SVG where local files are said to be read as text
SummaryLGTM. The new commits cover all three suggestions from my last review:
Accuracy check
Code quality / bugs / performance / securityThis PR only changes docs and docstrings, with no behaviour change. I found no bugs, performance issues or security issues. Test coverageNo new tests are needed. One optional idea: the |
The
FileSourcedocstring and the Limitations list indocs/how-to/use-local-files-and-urls.mdstill named only SVG as the exception to reading local files as raw text..drawioand.drawio.xmlfiles are also read through their extractor (DrawioExtractor). This brings both up to date. No behaviour change.Last loose end for #104.
just test: 1841 passed, mypy and ruff clean.🤖 Generated with Claude Code