fix: create secret only when provided - #594
Open
cxdy wants to merge 6 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
=======================================
Coverage 73.76% 73.76%
=======================================
Files 19 19
Lines 3045 3045
=======================================
Hits 2246 2246
Misses 538 538
Partials 261 261 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AshleyDumaine
temporarily deployed
to
prod-external
July 23, 2026 15:12 — with
GitHub Actions
Inactive
AshleyDumaine
temporarily deployed
to
prod-external
July 23, 2026 15:12 — with
GitHub Actions
Inactive
moshevayner
had a problem deploying
to
prod-external
July 23, 2026 20:03 — with
GitHub Actions
Error
moshevayner
had a problem deploying
to
prod-external
July 23, 2026 20:03 — with
GitHub Actions
Error
Match the CSI chart pattern: keep name/keys/path/mount defaults in values.yaml and read them directly from templates instead of hardcoding fallbacks when secretRef is unset.
AshleyDumaine
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this bug when upgrading the linode-ccm today (and trying to hot-load the API token)
Related PR: #576
Copy-cat PR for CSI: linode/linode-blockstorage-csi-driver#592
When updating to v0.9.7, I looked at the diff in ArgoCD and it didn't show the new Secret object, but the CSI (which I'm also updating) did show the new Secret object. Thought that was strange so we dug a little and noticed this:
linode-cloud-controller-manager/deploy/chart/templates/ccm-linode.yaml
Lines 1 to 11 in 373f204
if not .Values.secretRefdirectly conflicts with what I'm trying to do. In the CSI PR, we didif not .Values.apiTokeninstead:https://github.com/linode/linode-blockstorage-csi-driver/blob/main/helm-chart/csi-driver/templates/csi-secrets.yaml#L5-L15
Here's my valuesObject (same in both applications, only difference is
csi-linodeandccm-linodeforsecretRef.name:General:
Pull Request Guidelines: