[test] make e2e chainsaw tests clean up cloud resources on failure - #597
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
=======================================
Coverage 73.76% 73.76%
=======================================
Files 19 19
Lines 3045 3045
=======================================
Hits 2246 2246
Misses 538 538
Partials 261 261 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AshleyDumaine
approved these changes
Jul 23, 2026
Resources created directly via the Linode API (NodeBalancers, Firewalls, reserved IPs, the BGP IP-holder nanode) are not tracked by chainsaw and leaked when a step failed before the test's own delete ran. Add best-effort, idempotent cleanup in the test-level catch and step cleanup blocks so these are always released, and drop redundant skipDelete / manual delete steps where chainsaw already tears the resource down. Signed-off-by: Moshe Vayner <moshe@vayner.me>
Signed-off-by: Moshe Vayner <moshe@vayner.me>
These are no longer necessary. We will remove the BGP code in a followup PR Signed-off-by: Moshe Vayner <moshe@vayner.me>
moshevayner
force-pushed
the
cleanup-lbs-e2e
branch
from
July 23, 2026 19:08
08105f7 to
a70bbee
Compare
moshevayner
enabled auto-merge (squash)
July 23, 2026 19:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resources created directly via the Linode API (NodeBalancers, Firewalls, reserved IPs, the BGP IP-holder nanode) are not tracked by chainsaw and leaked when a step failed before the test's own delete ran. Add best-effort, idempotent cleanup in the test-level catch and step cleanup blocks so these are always released, and drop redundant skipDelete / manual delete steps where chainsaw already tears the resource down.
Also: add group name for vulnerability alerts in renovate configuration
General:
Pull Request Guidelines: