Skip to content

[test] make e2e chainsaw tests clean up cloud resources on failure - #597

Merged
moshevayner merged 3 commits into
mainfrom
cleanup-lbs-e2e
Jul 23, 2026
Merged

[test] make e2e chainsaw tests clean up cloud resources on failure#597
moshevayner merged 3 commits into
mainfrom
cleanup-lbs-e2e

Conversation

@moshevayner

@moshevayner moshevayner commented Jul 23, 2026

Copy link
Copy Markdown
Member

Resources created directly via the Linode API (NodeBalancers, Firewalls, reserved IPs, the BGP IP-holder nanode) are not tracked by chainsaw and leaked when a step failed before the test's own delete ran. Add best-effort, idempotent cleanup in the test-level catch and step cleanup blocks so these are always released, and drop redundant skipDelete / manual delete steps where chainsaw already tears the resource down.

Also: add group name for vulnerability alerts in renovate configuration

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@github-actions github-actions Bot added the testing for updates to the testing suite in the changelog. label Jul 23, 2026
@moshevayner moshevayner changed the title [test] make e2e chainsaw tests clean up cloud resources on failure Resources created directly via the Linode API (NodeBalancers, Firewalls, reserved IPs, the BGP IP-holder nanode) are not tracked by chainsaw and leaked when a step failed before the test's own delete ran. Add best-effort, idempotent cleanup in the test-level catch and step cleanup blocks so these are always released, and drop redundant skipDelete / manual delete steps where chainsaw already tears the resource down [test] make e2e chainsaw tests clean up cloud resources on failure Jul 23, 2026
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.76%. Comparing base (bc849f7) to head (a70bbee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #597   +/-   ##
=======================================
  Coverage   73.76%   73.76%           
=======================================
  Files          19       19           
  Lines        3045     3045           
=======================================
  Hits         2246     2246           
  Misses        538      538           
  Partials      261      261           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Resources created directly via the Linode API (NodeBalancers, Firewalls,
reserved IPs, the BGP IP-holder nanode) are not tracked by chainsaw and leaked when a step failed before the test's own delete ran. Add best-effort, idempotent cleanup in the test-level catch and step cleanup blocks so these are always released, and drop redundant skipDelete / manual delete steps where chainsaw already tears the resource down.

Signed-off-by: Moshe Vayner <moshe@vayner.me>
Signed-off-by: Moshe Vayner <moshe@vayner.me>
These are no longer necessary. We will remove the BGP code in a followup PR

Signed-off-by: Moshe Vayner <moshe@vayner.me>
@moshevayner
moshevayner enabled auto-merge (squash) July 23, 2026 19:08
@moshevayner
moshevayner merged commit 8e51020 into main Jul 23, 2026
11 of 12 checks passed
@moshevayner
moshevayner deleted the cleanup-lbs-e2e branch July 23, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing for updates to the testing suite in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants