Repository navigation
TPT-4727: Fix backups attempted update on non-editable last_successful - #748
Merged
Merged
Conversation
lgarber-akamai
requested review from
jriddle-linode and
mawilk90
and removed request for
a team
October 6, 2026 17:35
lgarber-akamai
force-pushed
the
fix/backups-update
branch
from
October 6, 2026 17:36
b52d1bf to
b7a8303
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change uses the existing serialization mechanism, has regression coverage, and has no unresolved findings.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes Linode instance updates sending read-only backup fields, such as last_successful, in PUT requests.
Changes:
- Adds structured backup models with a dedicated update schema.
- Preserves explicit null values for unset backup schedules.
- Extends fixtures and regression tests for backup parsing and serialization.
| File | Description |
|---|---|
| test/unit/objects/linode_test.py | Tests backup models and disabled-backup serialization. |
| test/fixtures/linode_instances.json | Adds read-only backup fields to fixture data. |
| linode_api4/objects/linode.py | Introduces backup models and limits serialized update fields. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
yec-akamai
approved these changes
Oct 6, 2026
yec-akamai
left a comment
yec-akamai
left a comment
Contributor
There was a problem hiding this comment.
Tests passed locally!
mawilk90
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request resolves a bug that caused
last_successful(read-only) to be sent along with the rest of the PUT request body when updating the backups enrollment for a Linode.This pull request fixes this by migrating the
backupsfield to a JSONObject with a dedicatedInstanceBackupsOptionsschema used for updates. To my knowledge this change is backwards compatible.This was causing the following error in CI:
✔️ How to Test
Integration Testing