Fix: NO_CAST.INTEGER_OVERFLOW - #553
Open
samitistfobos-dev wants to merge 1 commit into
Open
samitistfobos-dev wants to merge 1 commit into
samitistfobos-dev wants to merge 1 commit into
Conversation
Problem: The value of an arithmetic expression 'elem * ncur' is a subject to overflow because its operands are not cast to a larger data type before performing arithmetic Solution: Use a long variable for byte-size calculations in array_nextsize instead of performing the multiplication using int values. This avoids signed integer overflow in both the size comparison and the subsequent size calculation. Signed-off-by: a.burlakov@fobos-nt.ru Signed-off-by: dinchik@altlinux.org
Author
|
Patch for #552 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The value of an arithmetic expression 'elem * ncur' is a subject to overflow because its operands are not cast to a larger data type before performing arithmetic
Solution: Use a long variable for byte-size calculations in array_nextsize instead of performing the multiplication using int values. This avoids signed integer overflow in both the size comparison and the subsequent size calculation.
Signed-off-by: a.burlakov@fobos-nt.ru
Signed-off-by: dinchik@altlinux.org