Skip to content

ui: Remove process ID from credential prompt - #218

Merged
iinuwa merged 1 commit into
linux-credentials:mainfrom
mimi89999:ui_remove_pid
Aug 29, 2026
Merged

ui: Remove process ID from credential prompt#218
iinuwa merged 1 commit into
linux-credentials:mainfrom
mimi89999:ui_remove_pid

Conversation

@mimi89999

Copy link
Copy Markdown
Contributor

I fail to see how showing the PID would be of any use for the average user and could help them decide whether to proceed with the request

@iinuwa iinuwa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added some notes.

Could you add a note to the CHANGELOG? Adding your commit message under the [unreleased] version under a new ## Improvements section would work

Comment thread credentialsd-ui/src/gui/view_model/mod.rs Outdated
Comment thread credentialsd-ui/src/gui/view_model/mod.rs Outdated

@iinuwa iinuwa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Image

@iinuwa
iinuwa merged commit 2b70100 into linux-credentials:main Aug 29, 2026
1 check passed
@mimi89999
mimi89999 deleted the ui_remove_pid branch August 29, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants