tests/e2e: close per-test log files after tearDown cleanup runs - #3820
Merged
Conversation
tearDown closed stdout_log/stderr_log before calling create_and_attach_default_ns, which still runs nvme commands via run_cmd. Those writes hit the closed file handles, raising "ValueError: I/O operation on closed file" and failing every e2e test whose controller supports namespace management. Signed-off-by: Daniel Wagner dwagner@suse.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tearDown closed stdout_log/stderr_log before calling create_and_attach_default_ns, which still runs nvme commands via run_cmd. Those writes hit the closed file handles, raising "ValueError: I/O operation on closed file" and failing every e2e test whose controller supports namespace management.
Signed-off-by: Daniel Wagner dwagner@suse.com
Fixes: #3817