micron: fix logically dead code in micron_nand_stats() - #3821
Merged
Conversation
The micron_nand_stats() function conditionally fetches the 0xFB log page only for models where @emodel is not M5407 or M5410. The @has_fb_log flag is therefore always false for M5410, making the M5410 branch of the @SPEC ternary unreachable. The dead condition can never be true, so @SPEC is always assigned 1 regardless, which causes no incorrect output but is misleading and flagged as logically dead code by static analysis. Replace the ternary with a direct assignment of 1 and update the comment to reflect that M5410 is excluded by the guard above. Signed-off-by: Sarah Ahmed <sarah.ahmed@ibm.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The micron_nand_stats() function conditionally fetches the 0xFB log page only for models where eModel is not M5407 or M5410. The has_fb_log flag is therefore always false for M5410, making the M5410 branch of the spec ternary unreachable.
The dead condition can never be true, so spec is always assigned 1 regardless, which causes no incorrect output but is misleading and flagged as logically dead code by static analysis.
Replace the ternary with a direct assignment of 1 and update the comment to reflect that M5410 is excluded by the guard above.