wdc: fix logically dead code in wdc_do_cap_telemetry_log - #3830
Open
sahmed-ibm wants to merge 1 commit into
Open
wdc: fix logically dead code in wdc_do_cap_telemetry_log#3830sahmed-ibm wants to merge 1 commit into
sahmed-ibm wants to merge 1 commit into
Conversation
The wdc_do_cap_telemetry_log() function uses two flags, @host_gen and @ctrl_init, to select between three telemetry retrieval paths. @host_gen is initialized to 1 and is only ever set to 0 in the CONTROLLER branch, where @ctrl_init is also always set to 1. Because @ctrl_init and @host_gen can never both be 0, the final else branch calling libnvme_get_host_telemetry() is unreachable. The dead branch is misleading and adds unnecessary complexity. Remove @host_gen entirely and replace the three-way dispatch with a two-way branch on @ctrl_init: call libnvme_get_ctrl_telemetry() when set, and libnvme_get_new_host_telemetry() otherwise. Signed-off-by: Sarah Ahmed <sarah.ahmed@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wdc_do_cap_telemetry_log() function uses two flags, host_gen and ctrl_init, to select between three telemetry retrieval paths. host_gen is initialized to 1 and is only ever set to 0 in the CONTROLLER branch, where ctrl_init is also always set to 1.
Because ctrl_init and host_gen can never both be 0, the final else branch calling libnvme_get_host_telemetry() is unreachable. The dead branch is misleading and adds unnecessary complexity.
Remove host_gen entirely and replace the three-way dispatch with a two-way branch on ctrl_init: call libnvme_get_ctrl_telemetry() when set, and libnvme_get_new_host_telemetry() otherwise.