plugins/config: add 'nvme config status' command - #3832
Merged
Conversation
martin-belanger
force-pushed
the
config-status
branch
from
August 12, 2026 20:16
a295ace to
7536e51
Compare
Collaborator
|
Makes sense. The only thing I wonder if we should return an error code, so this command could be used in shell scripts without having to parse the output. The problem is no error is |
Add a command that reports on the legacy config files. It checks whether config.json/discovery.conf are present and whether they have already been converted to the new INI format (nvme-fabrics.conf), based on whether the rollback symlink is present next to each one. When a file has been converted, it hints that both the file and its symlink are safe to delete once rollback is no longer a concern. Signed-off-by: Martin Belanger <martin.belanger@dell.com>
martin-belanger
force-pushed
the
config-status
branch
from
August 13, 2026 10:02
7536e51 to
5a9c25e
Compare
Author
|
I added a return code as follows: |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a command that reports on the legacy config files. It checks whether config.json/discovery.conf are present and whether they have already been converted to the new INI format (nvme-fabrics.conf), based on whether the rollback symlink is present next to each one. When a file has been converted, it hints that both the file and its symlink are safe to delete once rollback is no longer a concern.