libnvme: normalize a comma-separated FC WWN pair in TID construction - #3833
Open
martin-belanger wants to merge 1 commit into
Open
libnvme: normalize a comma-separated FC WWN pair in TID construction#3833martin-belanger wants to merge 1 commit into
martin-belanger wants to merge 1 commit into
Conversation
fabrics.c already fixes this for discovery-log entries before they're used for candidate matching, but any other caller building a TID directly from FC fields (connect, a config file, ...) got a hard rejection instead. tid_sanitize_addr() already silently canonicalizes IP addresses the same way, so extend the same treatment to FC. Signed-off-by: Martin Belanger <martin.belanger@dell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fabrics.c already fixes this for discovery-log entries before they're used for candidate matching, but any other caller building a TID directly from FC fields (connect, a config file, ...) got a hard rejection instead. tid_sanitize_addr() already silently canonicalizes IP addresses the same way, so extend the same treatment to FC.