Skip to content

fix: make X11 bypass window manager hint configurable #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wjyrich wants to merge 1 commit into from
Closed

fix: make X11 bypass window manager hint configurable #1705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions frame/qml/PanelPopup.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Item {
property bool openPending: false
property bool grabInactivePending: false
property int grabInactiveTimeout: 200
property bool useX11BypassWindowManagerHint: true
// WM_NAME, used for kwin.
property string windowTitle: "dde-shell/panelpopup"
width: popup.childrenRect.width
Expand All @@ -43,6 +44,11 @@ Item {
target: popupWindow; property: "yOffset"
value: control.popupY
}
Binding {
when: readyBinding
target: popupWindow; property: "useX11BypassWindowManagerHint"
value: control.useX11BypassWindowManagerHint
}

function open()
{
Expand Down
7 changes: 6 additions & 1 deletion frame/qml/PanelPopupWindow.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ PopupWindow {
property int requestedWidth: 10
property int requestedHeight: 10
property bool geometryUpdatePending: false
// Individual popup instances can override this for window-manager compatibility.
property bool useX11BypassWindowManagerHint: true
signal requestUpdateGeometry()
signal updateGeometryFinished()

Expand Down Expand Up @@ -74,7 +76,10 @@ PopupWindow {

width: 10
height: 10
flags: (Qt.platform.pluginName === "xcb" ? (Qt.Tool | Qt.WindowStaysOnTopHint | Qt.X11BypassWindowManagerHint) : Qt.Popup)
flags: (Qt.platform.pluginName === "xcb"
? (Qt.Tool | Qt.WindowStaysOnTopHint
| (useX11BypassWindowManagerHint ? Qt.X11BypassWindowManagerHint : 0))
: Qt.Popup)
font: D.DTK.fontManager.t6
D.DWindow.enabled: true
D.DWindow.windowRadius: D.DTK.platformTheme.windowRadius < 0 ? 4 : D.DTK.platformTheme.windowRadius
Expand Down
Loading