Repository navigation
Conversation
rafaumeu
force-pushed
the
fix/flatpak-install-error-visible
branch
from
October 26, 2026 13:49
914a40f to
fadb18c
Compare
Member
|
Flatpak errors should be reported from the mintcommon installer, I'm not certain yet what's behind that not happening but I don't think this is the route to address it. Also, for future submissions, don't attach unrelated changes (like .gitignore). |
mtwebster
added a commit
that referenced
this pull request
Oct 26, 2026
- flatpak-update-worker: Don't quit before mintcommon's error dialog is shown. Show a dialog for errors that occur before the transaction is ready. - flatpakUpdater: Reset the error before each check/update. - Pass any flatpak check error into show_update_in_UI so the statusbar text can show the error. Fixes: #1082, #1050 Ref: #1103
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1082 and #1050.
Flatpak installation errors were only written to the log, so the update flow could appear successful.
Show the existing installation-error dialog and an error status when the Flatpak worker reports an error, while keeping the refresh behavior unchanged.
Tested with
python3 -m py_compile usr/lib/linuxmint/mintUpdate/mintUpdate.pyandgit diff --check../testwas not run because it modifies/usr.AI-assisted research and draft; independently reviewed and tested locally.