Skip to content

Don't refresh updates when closing Preferences without changes #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rafaumeu wants to merge 1 commit into from
Closed

Don't refresh updates when closing Preferences without changes #1105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion usr/lib/linuxmint/mintUpdate/mintUpdate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1670,7 +1670,7 @@ def _on_preferences_destroyed(self, window):
self.preferences_window = None
if self.app_restart_required:
self.restart_app()
else:
elif window.blacklist_changed:
self.refresh(False)

def restart_app(self):
Expand Down
5 changes: 4 additions & 1 deletion usr/lib/linuxmint/mintUpdate/preferences.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ class PreferencesWindow:
def __init__(self, parent, show_automation=False):
self.parent = parent
self.settings = parent.settings
self.blacklist_changed = False

gladefile = "/usr/share/linuxmint/mintupdate/preferences.ui"
builder = Gtk.Builder()
Expand Down Expand Up @@ -245,7 +246,9 @@ def _save_blacklist(self, treeview):
while iter is not None:
blacklist.append(model.get_value(iter, BLACKLIST_PKG_NAME))
iter = model.iter_next(iter)
self.settings.set_strv("blacklisted-packages", blacklist)
if blacklist != self.settings.get_strv("blacklisted-packages"):
self.settings.set_strv("blacklisted-packages", blacklist)
self.blacklist_changed = True

def _add_blacklisted_package(self, widget, treeview):
dialog = Gtk.MessageDialog(self.window,
Expand Down