feat(adk): scoped memory recall and domain type modernization (#704) - #705
Open
cofin wants to merge 1 commit into
Open
feat(adk): scoped memory recall and domain type modernization (#704)#705cofin wants to merge 1 commit into
cofin wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
==========================================
- Coverage 77.47% 77.01% -0.46%
==========================================
Files 487 487
Lines 68387 68890 +503
Branches 9418 9525 +107
==========================================
+ Hits 52983 53057 +74
- Misses 11998 12422 +424
- Partials 3406 3411 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements scoped memory recall levels for the Google ADK memory store extension (resolving #704) along with domain type modernization, singular table names across all 14 database dialect adapters, and canonical migration consolidation.
Key Changes
scope VARCHAR(16) NOT NULL DEFAULT 'user'toadk_memorytable DDL across all 14 database adapters.(app_name, scope, user_id, timestamp DESC)and(app_name, scope).scope = 'user' AND user_id = :user_id) and app-scoped memory (scope = 'app' AND app_name = :app_name).scope_filter: Literal['all', 'user', 'app'] = 'all'.scope: str = 'user'parameter to memory ingestion methods (add_memories,add_events_to_memory,add_session_to_memory).delete_entries_older_than(days, app_name=None, scope=None).StoredMemory,StoredSession,StoredEvent,StoredArtifact.MemoryRecord,SessionRecord, etc.).adk_session,adk_event,adk_memory,adk_app_state,adk_user_state,adk_artifact,adk_internal_metadata.0001_create_adk_tables.pyto generate the singular schema withscopedirectly.Verification
make lint: 100% passed (Ruff, Prek, slotscheck, codespell, sphinx-lint, zizmor)make type-check: 100% passed (Mypy + Pyright, 0 errors)uv run pytest tests/unit/: 9,222 passed, 0 failed, 26 skipped