fix(aio): drain blocked senders when closing channels - #7257
Open
Kuang-xianxin wants to merge 1 commit into
Open
fix(aio): drain blocked senders when closing channels#7257Kuang-xianxin wants to merge 1 commit into
Kuang-xianxin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a full bounded
Chanwakes blocked senders but leaves their completed futures in_puts. A secondclose(), either immediately or after the senders finish, callsset_exception()on those futures and raisesInvalidStateErrorduring shutdown.Drain the sender waiters when closing and only signal unfinished futures. Regression tests exercise both close timings through the public channel API, verify that all blocked senders receive
ChanClosed, and that the buffered item remains readable.Validation:
34a4e8f; the 12 existing tests intest_aio.pypass there.tests/test_aio.pyandtests/test_aio_itertools.pypass on Python 3.13.14.git diff --checkpass.livekit.plugins.anampy.typedmarker, identically on the unchanged base. The full SDK/provider integration suite was not run locally.