Sample apps using the Token Source implementations - #995
Merged
Conversation
🦋 Changeset detectedLatest commit: 1ed3e38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MaxHeimbrock
force-pushed
the
sample-app-compose-token-source
branch
from
August 4, 2026 15:34
75b6d5c to
1af3462
Compare
MaxHeimbrock
force-pushed
the
sample-app-compose-token-source
branch
from
August 5, 2026 08:38
1af3462 to
67167da
Compare
MaxHeimbrock
marked this pull request as ready for review
August 5, 2026 08:41
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
davidliu
force-pushed
the
sample-app-compose-token-source
branch
from
August 5, 2026 09:59
ffcdf3f to
4ad11c3
Compare
Contributor
|
Diffuse output: AAR |
…option The connect screens of sample-app and sample-app-compose get two tabs: the existing literal URL/token entry and a new development token server mode that takes a token server ID. Both paths now go through the SDK's TokenSource API: the shared CallViewModel receives a parcelable TokenSourceArgs and fetches connection details at connect time via TokenSource.fromLiteral or TokenSource.fromDevelopmentTokenServer before calling room.connect. The token server ID is persisted alongside the existing url/token preferences and can be defaulted via the livekitSampleTokenServerId gradle property. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The dev token server tab in both sample apps now takes optional room name, participant name, participant identity, and agent name inputs. They travel through TokenSourceArgs.DevTokenServer and are passed to the token source fetch as TokenRequestOptions; blank fields are treated as unset so the server defaults apply. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ials Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
MaxHeimbrock
force-pushed
the
sample-app-compose-token-source
branch
from
August 5, 2026 10:14
4ad11c3 to
c8d2075
Compare
davidliu
reviewed
Aug 5, 2026
davidliu
approved these changes
Aug 5, 2026
Contributor
|
Both PRs LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Token Sources in our samples:
LiteralTokenSourcefor the existing path.Adding a second tab for connecting via
DevelopmentTokenSourcefor: