Surface newer server disconnect reasons as distinct DisconnectReason values - #1157
Closed
hiroshihorie wants to merge 1 commit into
Closed
Conversation
…values The protocol defines nine disconnect reasons the public enum had no members for, so they were all reported as unknown. Add members for them and map them in toSDKType.
hiroshihorie
added a commit
that referenced
this pull request
Aug 8, 2026
…values (#1158) Follow-up to #1156 (replaces #1157, which GitHub auto-closed when the stack base merged). The protocol defines 17 disconnect reasons but the public `DisconnectReason` enum only had members for 8 of them, so newer reasons arriving in a leave request (for example when the server closes a room or a SIP trunk fails) were all collapsed to `unknown`. This adds members for the nine missing reasons and maps them in `toSDKType`: `migration`, `signalClose`, `roomClosed`, `userUnavailable`, `userRejected`, `sipTrunkFailure`, `connectionTimeout`, `mediaFailure`, `agentError` Unrecognized values from servers newer than the SDK still fall back to `unknown` via the wildcard arm introduced in #1156. Note for apps: adding enum members means an exhaustive `switch` over `DisconnectReason` in app code will need new cases, which is why the changeset is `minor`. ## Tests New `test/types/disconnect_reason_test.dart` asserts every proto value maps to a distinct SDK value and pins the nine new mappings. Full suite passes (380 tests), analyze, format, and import sorter clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1156, review that first. Only the last commit (
87a9753) is new here.The protocol defines 17 disconnect reasons but the public
DisconnectReasonenum only had members for 8 of them, so newer reasons arriving in a leave request (for example when the server closes a room or a SIP trunk fails) were all collapsed tounknown. This adds members for the nine missing reasons and maps them intoSDKType:migration,signalClose,roomClosed,userUnavailable,userRejected,sipTrunkFailure,connectionTimeout,mediaFailure,agentErrorUnrecognized values from servers newer than the SDK still fall back to
unknownvia the wildcard arm introduced in #1156.Note for apps: adding enum members means an exhaustive
switchoverDisconnectReasonin app code will need new cases, which is why the changeset isminor.Tests
New
test/types/disconnect_reason_test.dartasserts every proto value maps to a distinct SDK value and pins the nine new mappings. Full suite passes (380 tests), analyze, format, and import sorter clean.🤖 Generated with Claude Code