Skip to content

chore: pb v1.53.0 - #1252

Merged
hiroshihorie merged 1 commit into
mainfrom
hiroshi/pb-v1.53.0
Oct 23, 2026
Merged

hiroshihorie merged 1 commit into
mainfrom
hiroshi/pb-v1.53.0

Conversation

@hiroshihorie

Copy link
Copy Markdown
Member

No description provided.

@hiroshihorie
hiroshihorie marked this pull request as ready for review October 22, 2026 21:14

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

Comment on lines +136 to +138
static const DataTrackExtensionID DTEI_E2EE = DataTrackExtensionID._(1, _omitEnumNames ? '' : 'DTEI_E2EE');
static const DataTrackExtensionID DTEI_USER_TIMESTAMP =
DataTrackExtensionID._(2, _omitEnumNames ? '' : 'DTEI_USER_TIMESTAMP');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Protocol update lacks a changeset

Publishing the new DataTrackExtensionID values has no corresponding changeset in this PR. The protocol update goes undocumented in the release changelog.

Learn more

The generated protobuf enums are part of the published package. Release rules require a new .changes/ file for every PR that affects that package. This PR only modifies protobuf output, so its existing changeset files do not describe the update.

Example: After release, a user reviewing the changelog sees no entry for the added data-track extension IDs.

Recommended fix: Add a new .changes/ file with the required level, type, and description for this protocol update; keep generated protobuf files unchanged by hand.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@hiroshihorie
hiroshihorie merged commit 43b0d94 into main Oct 23, 2026
15 checks passed
@hiroshihorie
hiroshihorie deleted the hiroshi/pb-v1.53.0 branch October 23, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants