Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: f03ba6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alexlivekit
approved these changes
Nov 2, 2026
hechen-eng
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lk.sip.inviteTimerecords when an inbound call arrives. Two more SIP times are needed to measure how long a caller waits for an agent. On an inbound PIN call, part of the wait is the caller entering the PIN. On an outbound call, the callee is there only once they answer.Change
lk.sip.pinEnteredTime: when the caller finished entering the PIN on an inbound PIN call, in Unix milliseconds.lk.sip.answerTime: when the callee answered an outbound call, in Unix milliseconds.InviteTimeAttributesandParseInviteTime.livekit/sip#948 sets both attributes.
Verified
go test ./sip/ -run TestTimeAttributespasses for all three attributes, including missing and malformed values.🤖 Generated with Claude Code