Repository navigation
Correct the ParticipantInfo JOINED state comment - #1931
Open
GSmithApps wants to merge 1 commit into
Open
GSmithApps wants to merge 1 commit into
GSmithApps wants to merge 1 commit into
Conversation
The server sets JOINED right after it sends the join response (livekit/pkg/rtc/participant_signal.go), not when it receives the client's offer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
GSmithApps
marked this pull request as ready for review
November 2, 2026 21:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParticipantInfo.State.JOINEDwas documented as "server received client offer". The server actually sets JOINED right after it writes the join response, before any offer (livekit/pkg/rtc/participant_signal.go,updateState(JOINED)afterSignalJoinResponse).This updates the
.protocomment and the same line inlivekit_models.pb.go, which is what the Generate workflow would produce. Comment only.🤖 Generated with Claude Code